NPI-3653 - Update code to handle new V2 IGS logs #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seballgeyer
requested changes
Dec 12, 2024
gnssanalysis/gn_io/igslog.py
Outdated
| @@ -109,21 +134,25 @@ def parse_igs_log(filename_array: _np.ndarray) -> _np.ndarray: | |||
| with open(file_path, "rb") as file: | |||
| data = file.read() | |||
|
|
|||
| blk_id = _REGEX_ID.search(data) | |||
| blk_id = _REGEX_ID_V2.search(data) | |||
There was a problem hiding this comment.
an unit test can be good so we can have a quick check if it works or not?
seballgeyer
reviewed
Dec 13, 2024
seballgeyer
reviewed
Dec 13, 2024
seballgeyer
reviewed
Dec 13, 2024
seballgeyer
reviewed
Dec 13, 2024
seballgeyer
requested changes
Dec 18, 2024
gnssanalysis/gn_io/igslog.py
Outdated
| elif result_v2 is not None: | ||
| return "v2.0" | ||
| else: | ||
| return "Unknown" |
There was a problem hiding this comment.
comment only/suggestion.
I would probably raise in exception if it is Unkown
Suggested change
| return "Unknown" | |
| class LogVersionError(Exeption): | |
| """Custom exception raised when an uknown log version is encountered.""" | |
| pass | |
| ... in the code ... | |
| else: | |
| raise LogVersionError("Unknown log version") | |
| return "Unknown" |
ronaldmaj
commented
Dec 20, 2024
gnssanalysis/gn_io/igslog.py
Outdated
| elif result_v2 is not None: | ||
| return "v2.0" | ||
| else: | ||
| return "Unknown" |
seballgeyer
requested changes
Dec 20, 2024
| try: | ||
| version = determine_log_version(data) | ||
| except LogVersionError as e: | ||
| logger.warning(f"Error: {e}, skipping parsing the log file") |
There was a problem hiding this comment.
in this case, when the exception is raised, the code will still continue even if the version is uknown,
I am not sure what do we want to do.
one option is to stop the function (either re- raise
except LogVersionError as e:
logger.warning(...)
raiseor just an empty return
except .....
logger.warning(....)
return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick PR to update the code to handle new metadata fields in IGS log files.
This will still be able to read and process the old IGS log files as well (backwards compatible)