Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Changes being made
Give examples of the changes you've made in this pull request. Include an itemized list if you can.
Parameter
subclassMultiSource
ValidateParameters#validate
to handleexpected_delivery_types
as a list ofParameter
s, return the first successful match, or error if no match found in any of the types🧠 Rationale behind the change
Why did you choose to make these changes?
Does this pull request resolve any open issues?
Yes. Closes #43
Were there any trade-offs you had to consider?
Usage syntax and behavior customization:
string: str = MultiSource(Query, Json, min_int=0)
- can't specify validation conditions per parameter type, but it's easier to write outstring: str = MultiSource([Query(min_int=0), Json(min_int=0)
- could allow for more customization in usage, but for the average user it's a worse experience🧪 Testing
Have tests been added or updated for the changes introduced in this pull request?
Are the changes backwards compatible?
If the changes aren't backwards compatible, what other options were explored?
✨ Quality check
Are your changes free of any erroneous print statements, debuggers or other leftover code?
Has the README been updated to reflect the changes introduced (if applicable)?
💬 Additional comments
Feel free to add any further information below
Dependent on #45