Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSTM layer in Flux v0.15.0 returns a tuple of
(h, c)
wheresize(h)==(in_dim, timesteps, batch_size)
. This is in contrast with any other framework (pytorch, flax, lux), where onlyh
is returned as an output. Due to this, we cannot stack LSTM in aChain
.With this PR, the LSTM returns only
h
. While this change is breaking, v0.15 has only been around for a few days so we can consider the current behavior a bug introduced while doing the redesign in #2500, fix it now and tag a v0.15.3 as soon as possible.cc @MartinuzziFrancesco