[Feature] Add prompt to RetreivalQAChain #3702
Open
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would you like to take an attempt to do it in this PR? using the new way via |
|
@HenryHengZJ sure i can, i'll do it by the end of week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Flowise,
This PR adds the ability to link a prompt template to
RetrievalQAChain(it's also achievable forMultiRetrievalQAChainbut this one targetsPromptTemplateinstead ofBasePromptTemplate, so it would implies a lot on refacto)promptinput (optional to prevent breaking changes and fit langchain behavior)RetrievalQAChain@HenryHengZJ BTW it would be great to update
RetrievalQAChainlogic asRetrievalQAChainis deprecated by langchain. (will be removed on 1.0.0)