Issue 13 read zip #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost#13 - use `index.hbs` to detect where in the zip file the theme lives - add some tests to show how this works
- call fetch on boot, it will likely be done by the time the first request comes in - if it isn't, it doesn't really matter - then call fetch again when the ttl runs out - TODO: do this some better way
- add express-hbs & handlebars helpers that were missed - add old and brand-new Ghost helpers so that we support the latest version
- Refactor how the zip is deleted, to try to prevent the app from crashing - Add error handling - Add forced default layout - Improve result output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing