Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minimal Implementation for Shortcuts in the Tracker Fields #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Minimal Implementation for Shortcuts in the Tracker Fields #60

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c478ce6
Add minimal implementation for shortcuts in the tracker fields
serrnovik Nov 4, 2024
40170e4
Add Reporting Summary API and examples
serrnovik Nov 4, 2024
f79e76c
Revert "Add Reporting Summary API and examples"
serrnovik Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 71 additions & 23 deletions src/tracker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,31 +382,65 @@ function addEditableTableRow(tracker: Tracker, entry: Entry, table: HTMLTableEle
.setTooltip("Edit")
.setIcon("lucide-pencil")
.onClick(async () => {
if (nameField.editing()) {
entry.name = nameField.endEdit();
expandButton.buttonEl.style.display = null;
startField.endEdit();
entry.startTime = startField.getTimestamp();
if (!entryRunning) {
endField.endEdit();
entry.endTime = endField.getTimestamp();
}
await saveTracker(tracker, getFile(), getSectionInfo());
editButton.setIcon("lucide-pencil");
await handleEdit();
});

renderNameAsMarkdown(nameField.label, getFile, component);
} else {
nameField.beginEdit(entry.name);
expandButton.buttonEl.style.display = "none";
// only allow editing start and end times if we don't have sub entries
if (!entry.subEntries) {
startField.beginEdit(entry.startTime);
if (!entryRunning)
endField.beginEdit(entry.endTime);
}
editButton.setIcon("lucide-check");
// Add double-click to edit functionality
nameField.label.addEventListener('dblclick', async () => {
if (!nameField.editing()) {
await handleEdit();
}
});

async function handleEdit() {
if (nameField.editing()) {
await saveChanges();
} else {
startEditing();
}
}

async function saveChanges() {
entry.name = nameField.endEdit();
expandButton.buttonEl.style.display = null;
startField.endEdit();
entry.startTime = startField.getTimestamp();
if (!entryRunning) {
endField.endEdit();
entry.endTime = endField.getTimestamp();
}
await saveTracker(tracker, getFile(), getSectionInfo());
editButton.setIcon("lucide-pencil");
renderNameAsMarkdown(nameField.label, getFile, component);
}

function startEditing() {
nameField.beginEdit(entry.name);
expandButton.buttonEl.style.display = "none";
// only allow editing start and end times if we don't have sub entries
if (!entry.subEntries) {
startField.beginEdit(entry.startTime);
if (!entryRunning)
endField.beginEdit(entry.endTime);
}
editButton.setIcon("lucide-check");

// Set up save/cancel handlers for keyboard shortcuts
nameField.onSave = startField.onSave = endField.onSave = async () => {
await saveChanges();
};

nameField.onCancel = startField.onCancel = endField.onCancel = () => {
nameField.endEdit();
startField.endEdit();
if (!entryRunning) {
endField.endEdit();
}
});
expandButton.buttonEl.style.display = null;
editButton.setIcon("lucide-pencil");
};
}

new ButtonComponent(entryButtons)
.setClass("clickable-icon")
.setTooltip("Remove")
Expand Down Expand Up @@ -449,6 +483,8 @@ class EditableField {
cell: HTMLTableCellElement;
label: HTMLSpanElement;
box: TextComponent;
onSave?: () => void;
onCancel?: () => void;

constructor(row: HTMLTableRowElement, indent: number, value: string) {
this.cell = row.createEl("td");
Expand All @@ -457,6 +493,18 @@ class EditableField {
this.box = new TextComponent(this.cell).setValue(value);
this.box.inputEl.addClass("simple-time-tracker-input");
this.box.inputEl.hide();
this.box.inputEl.addEventListener('keydown', (e: KeyboardEvent) => {
// Save with Ctrl/Cmd + Enter
if (e.key === 'Enter') {
e.preventDefault();
this.onSave?.();
}
// Cancel with Escape
if (e.key === 'Escape') {
e.preventDefault();
this.onCancel?.();
}
});
}

editing(): boolean {
Expand Down