Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Prettier husky #415

Closed
wants to merge 9 commits into from
Closed

Conversation

Bashamega
Copy link
Member

Hello:)

I have integrated prettier in husky

@Bashamega
Copy link
Member Author

Hello @eddiejaoude :) Can you please merge this pr

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please exclude CHANGELOG.md file as this is autogenerated and will cause conflicts

@eddiejaoude
Copy link
Member

eddiejaoude commented Aug 3, 2024

Hello @eddiejaoude :) Can you please merge this pr

Do you mean "review this PR"? BTW the extra notifications are not required

@Cahllagerfeld are you able to review?

@Bashamega
Copy link
Member Author

the extra notifications is not required

Sorry for the notification

@eddiejaoude
Copy link
Member

thank you for understanding 👍

@Bashamega
Copy link
Member Author

Thank you. Please exclude CHANGELOG.md file as this is autogenerated and will cause conflicts

It should be excluded because of the prettier ignore.

@eddiejaoude
Copy link
Member

Thank you. Please exclude CHANGELOG.md file as this is autogenerated and will cause conflicts

It should be excluded because of the prettier ignore.

Oh strange, there are changes to the file https://github.com/EddieHubCommunity/good-first-issue-finder/pull/415/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed

@eddiejaoude
Copy link
Member

Strange why the ignore file is not being used, here are the official docs and the filename is correct https://prettier.io/docs/en/ignore.html

@Bashamega
Copy link
Member Author

Strange why the ignore file is not being used, here are the official docs and the filename is correct https://prettier.io/docs/en/ignore.html

Is it because we are using husky? I don't know how to fix it

@eddiejaoude
Copy link
Member

Is it because we are using husky? I don't know how to fix it

I don't think they are related or causing any issues. I see you have joined EddieHub Discord, let's continue the chat there and publish the conclusion here afterwards

@Bashamega
Copy link
Member Author

Hello:)

I have fixed the issue. The issue was that instead of specifying .prettierignore we were specifying the .gitignore. I have now fixed it.

@Bashamega Bashamega requested a review from eddiejaoude August 7, 2024 07:44
.husky/pre-commit Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
* caprover config ([38521e0](https://github.com/EddieHubCommunity/good-first-issue-finder/commit/38521e035edc251675ad28f5914aac477c4c5fae))





Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore this file as it is auto generated

@Bashamega Bashamega requested a review from eddiejaoude August 13, 2024 03:28
@Bashamega Bashamega closed this by deleting the head repository Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants