Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

Upgrade svelte to 4.2.1 along with its dependants #382

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Upgrade svelte to 4.2.1 along with its dependants #382

merged 8 commits into from
Oct 11, 2023

Conversation

tbhaxor
Copy link
Member

@tbhaxor tbhaxor commented Oct 7, 2023

Fixes Issue

Fixes #362

Changes proposed

  • Bump postcss to 8.4.31
  • Upgrade svelte to 4.2.1 along with its dependants to appropriate versions
  • Replace eslint-plugin-svelte3 with eslint-plugin-svelte
  • Reformat .eslintrc.js file

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when running npm run format, I'm getting a log with a warning related to plugins. Also in the list are no files listed with the .svelte extension. I think there might be something wrong with the prettier setup or the updated prettier version, can you please check this again

[warn] Ignored unknown option --plugin-search-dir=..
.eslintrc.cjs 51ms
.github/ISSUE_TEMPLATE/bug.yml 31ms
.github/ISSUE_TEMPLATE/config.yml 3ms
.github/ISSUE_TEMPLATE/docs.yml 8ms
.github/ISSUE_TEMPLATE/feature_request.yml 7ms
.github/ISSUE_TEMPLATE/other.yml 5ms
.github/workflows/build.yml 5ms
.github/workflows/deploy.yml 12ms
.github/workflows/kubescape.yml 4ms
.github/workflows/labels.yml 3ms
.github/workflows/release.yml 5ms
.github/workflows/test.yml 5ms
.gitpod.yml 4ms
.prettierrc 5ms
CHANGELOG.md 41ms
CODE_OF_CONDUCT.md 38ms
CONTRIBUTING.md 35ms
histoire.config.ts 156ms
kubernetes/deployment.yaml 6ms
kubernetes/ingress.yaml 5ms
kubernetes/service.yaml 3ms
mdsvex.config.js 8ms
package-lock.json 138ms
package.json 2ms
playwright.config.ts 10ms
postcss.config.cjs 6ms
README.md 21ms
SECURITY.md 3ms
src/app.css 29ms
src/app.d.ts 6ms
src/app.html 24ms
src/error.html 6ms
src/global.d.ts 20ms
src/histoire-setup.ts 5ms
src/hooks.server.ts 8ms
src/lib/constants.json 2ms
src/lib/contents/docs-menu.ts 3ms
src/lib/data.ts 10ms
src/lib/stores/show-hamburger-menu.ts 2ms
src/lib/util/font-color-calculator.ts 11ms
src/lib/util/hide-overflow.ts 3ms
src/lib/util/version.ts 1ms
src/routes/+layout.server.ts 2ms
src/routes/+layout.ts 5ms
src/routes/api/authentication/callback/+server.ts 16ms
src/routes/api/authentication/login/+server.ts 7ms
src/routes/api/authentication/logout/+server.ts 5ms
src/routes/api/get-issues/+server.ts 13ms
src/routes/api/version/+server.ts 3ms
src/routes/app/+page.ts 6ms
src/routes/docs/+page.md 8ms
src/routes/docs/testing/+page.md 17ms
src/routes/docs/your-issues/+page.md 6ms
static/css/error.css 6ms
static/js/theme.js 7ms
static/prism.css 16ms
svelte.config.js 4ms
tailwind.config.cjs 5ms
tests/docs/introduction.spec.ts 7ms
tests/login.spec.ts 16ms
tsconfig.json 2ms
vite.config.ts 2ms

A similar thing for the lint script, it also returns some errors that haven't been thrown before (snippet isn't all just an example)

/workspace/good-first-issue-finder/src/lib/components/checkbox.svelte
  3:19  error  Parsing error: Unexpected token :

/workspace/good-first-issue-finder/src/lib/components/docs/menu-item.svelte
  3:22  error  Parsing error: Unexpected token :

/workspace/good-first-issue-finder/src/lib/components/filter.svelte
  3:18  error  Parsing error: Unexpected token :

/workspace/good-first-issue-finder/src/lib/components/hamburger-menu/menu.svelte
  8:22  error  Parsing error: Unexpected token :

@tbhaxor
Copy link
Member Author

tbhaxor commented Oct 7, 2023

Yeah, I am using updated prettier version. Let me check. I thought it would work. Thanks for checking for me.

@tbhaxor
Copy link
Member Author

tbhaxor commented Oct 8, 2023

It should work now @Cahllagerfeld

package.json Outdated Show resolved Hide resolved
@tbhaxor
Copy link
Member Author

tbhaxor commented Oct 9, 2023

@Cahllagerfeld Ping 0x01

Copy link
Member

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the merge conflicts are resolved it looks good to merge 👍

@tbhaxor
Copy link
Member Author

tbhaxor commented Oct 9, 2023

@Cahllagerfeld Good to go now

@Cahllagerfeld Cahllagerfeld merged commit e7543e5 into EddieHubCommunity:main Oct 11, 2023
1 check passed
@tbhaxor tbhaxor deleted the issue-362 branch October 11, 2023 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Migrate to Svelte 4
2 participants