i#2283: Adds more scales to Umbra #2309
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #2310 |
Added the fixes to this PR after all. |
|
@derekbruening Not sure if you are aware that this PR is ready for review. No rush though as I am busy with work, so feel free to look at it at your convenience. |
derekbruening
approved these changes
Sep 6, 2020
| UMBRA_MAP_SCALE_UP_2X, /** 1 app byte to 2 shadow byte */ | ||
| UMBRA_MAP_SCALE_UP_4X, /** | ||
| * 1 app byte to 4 shadow bytes. | ||
| * Reserve regions not supported (applies only for 64-bit). |
There was a problem hiding this comment.
Does the user know what a "Reserve region" is? Not seeing it anywhere...ok it's right above in the new comments. Maybe point there?
There was a problem hiding this comment.
The doc you mentioned pertains to the same enum def. If I place a doxygen link, it's just going to take the reader to the enum.
|
Many thanks for the review. I have tested many of the features in my tools' code-bases. However, I'll write some quick sample tools and include them in this PR. |
johnfxgalea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more scales to Umbra. In particular, the following scales are added:
Adds support for both 32-bit and 64-bit architectures.
Issue: #2283