Add alternate version of some inverse CDFR functions #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Colvin
reviewed
Oct 28, 2017
| * invChiSquareCDFR, create new invChiSquareCDFR and deprecate an alias | ||
| * to this function. | ||
| */ | ||
| double invChiSquareCDFR_Alt(double p, double v) { |
There was a problem hiding this comment.
need better names than _Alt. I'm concerned about anything where two double parameters get swapped around, so I'd be happier to create a new function name that we actually keep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing item 1 in issue #29
I created alternate version of two inverse CDFR functions whose API does not match the original. I then deprecated the original functions. After a period has passed, the original functions can be resurrected with the new, consistent type signatures and the alternate version can be deprecated.