Change auto-update of rare slim to include children of rare diseases #1217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the make rule that automatically adds diseases to the DO_rare_slim. The original version (still currently active) adds diseases with ORDO or GARD xrefs only. This change would also add any disease that is a child of those diseases.
While this seems theoretically correct, there are a surprising number of diseases added and it seems likely they are not all rare (particularly for cancers).
Instead of implementing this as is, it might be wise to first accomplish one or more of the following and then revise the theory of what is considered rare: