-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-7180 SwiftUI Benchmark Scenario #2146
base: develop
Are you sure you want to change the base?
Conversation
55afe0e
to
8d94343
Compare
@maxep Would it be possible to consider bundling the images differently, skipping some, or resizing them to help reduce the impact on the repository size? The total size of the images in this PR is 1.5MB, which adds over 10% to the current size of the repository (<15MB). |
@ncreated Yes, totally 👍 |
d6ad6aa
to
6698ac0
Compare
Thank you for the initial review! I apology for such a large PR, most of it is from SwiftUICatalog which was convenient to build an app that covers a large set of SwiftUI component. I'm not expecting a review on this framework implementation, The only custom part is BenchmarkTests/SwiftUICatalog/DatadogMonitor.swift which is used to instrument RUM views. |
BenchmarkTests/Runner/Scenarios/SessionReplay/SessionReplaySwiftUIScenario.swift
Outdated
Show resolved
Hide resolved
6698ac0
to
f2d89b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌. My only ask is to update the LICENSE-3rdparty.csv
. I think it should also mention the UIKitCatalog
.
IPHONEOS_DEPLOYMENT_TARGET = 13.0; | ||
IPHONEOS_DEPLOYMENT_TARGET = 17.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion/ We have two xcconfig
files set up for Benchmarks project, this setting could easily go there to simplify configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xcconfig
is currently applied to the Runner
target only.
What I did instead is set the IPHONEOS_DEPLOYMENT_TARGET
at the project level and remove overrides in the targets.
7d6803b
to
5a193aa
Compare
Datadog ReportBranch report: ✅ 0 Failed, 553 Passed, 3057 Skipped, 19.3s Total duration (2m 11.97s time saved) |
1ab0d94
to
d868115
Compare
What and why?
Add a Session Replay SwiftUI scenario for continuous benchmarking.
Note: Everything under
BenchmarkTests/SwiftUICatalog
is 3rd party.How?
Integrate with the third-party SwiftUICatalog in a similar fashion than UIKitCatalog.
The scenario will go through multiple SwiftUI components to measure pre-defined metrics.
Review checklist
make api-surface
)