Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if key supports batch API in Map() ctor #32348

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

usamasaqib
Copy link
Contributor

What does this PR do?

Fix bug introduced in #29220 which does not set keySupportsBatchAPI boolean in the Map() constructor for a generic map.

Motivation

Describe how you validated your changes

Changes validated by new test added in this PR.

Possible Drawbacks / Trade-offs

Additional Notes

@usamasaqib usamasaqib added changelog/no-changelog team/ebpf-platform qa/done QA done before merge and regressions are covered by tests labels Dec 18, 2024
@usamasaqib usamasaqib added this to the 7.62.0 milestone Dec 18, 2024
@usamasaqib usamasaqib requested a review from a team as a code owner December 18, 2024 15:31
@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly labels Dec 18, 2024
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 18, 2024
Copy link
Contributor

@val06 val06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment on test

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 18, 2024

Uncompressed package size comparison

Comparison with ancestor d598917c9843de41c0178306f41a91705f2ed6d5

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.02MB ⚠️ 933.79MB 933.77MB 140.00MB
datadog-agent-aarch64-rpm 0.02MB ⚠️ 943.00MB 942.98MB 140.00MB
datadog-heroku-agent-amd64-deb 0.00MB ⚠️ 505.06MB 505.06MB 70.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.67MB 78.67MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.67MB 78.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.79MB 55.79MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.31MB 113.31MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.38MB 113.38MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.78MB 108.78MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.85MB 108.85MB 10.00MB
datadog-agent-amd64-deb -0.00MB 1187.76MB 1187.76MB 140.00MB
datadog-agent-x86_64-rpm -0.00MB 1196.99MB 1196.99MB 140.00MB
datadog-agent-x86_64-suse -0.00MB 1196.99MB 1196.99MB 140.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 18, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51467649 --os-family=ubuntu

Note: This applies to commit 7545c42

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Dec 18, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51467649 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 94426f0a-ce12-4ff1-863b-9148e7b1613d

Baseline: d598917
Comparison: 7545c42
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +2.08 [+1.97, +2.20] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.72 [+0.63, +0.80] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.13 [-0.72, +0.98] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.11 [-0.62, +0.84] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.68, +0.86] 1 Logs
file_tree memory utilization +0.08 [-0.04, +0.21] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.68, +0.82] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.07 [-0.69, +0.83] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.06 [-0.69, +0.57] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.10 [-0.96, +0.76] 1 Logs
quality_gate_idle memory utilization -0.14 [-0.19, -0.09] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.21 [-0.67, +0.25] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.39 [-1.19, +0.41] 1 Logs
quality_gate_logs % cpu utilization -0.47 [-3.36, +2.42] 1 Logs
otel_to_otel_logs ingress throughput -1.49 [-2.21, -0.78] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@usamasaqib
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-19 09:39:39 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.


2024-12-19 09:47:50 UTC ℹ️ MergeQueue: Retrying because previous merge request failed


2024-12-19 10:25:17 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 091e10e into main Dec 19, 2024
305 checks passed
@dd-mergequeue dd-mergequeue bot deleted the usama.saqib/fix-batch-api-use-check branch December 19, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants