Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_bias parameter to create_mlp #1188

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Add with_bias parameter to create_mlp #1188

merged 6 commits into from
Nov 29, 2022

Conversation

qgallouedec
Copy link
Collaborator

@qgallouedec qgallouedec commented Nov 29, 2022

Description

It would allow to make ARSLinearPolicy a special case of ARSPolicy

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

(I didn't raise an issue as it seems not to be a big new feature)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@araffin
Copy link
Member

araffin commented Nov 29, 2022

Do you think it would make sense to include layer norm and dropout in this PR? (see #1069, this is to implement REDQ/DroQ as in #1036)

or do you prefer if I do that in a separate PR?

@qgallouedec
Copy link
Collaborator Author

I would prefer to do it in a separate PR, because you would have to add tests and stuff.

@qgallouedec
Copy link
Collaborator Author

a60cd1d
Wrong message, read instead "move with_bias to the last position"

@araffin araffin merged commit 5cd8913 into master Nov 29, 2022
@araffin araffin deleted the with-bias-create-mlp branch November 29, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants