-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #76
Open
arrabyte
wants to merge
23
commits into
CryptoGnome:main
Choose a base branch
from
arrabyte:develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Develop #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arrabyte
commented
Sep 13, 2023
- Some fixes
- Classical DCA orders features with limit orders placed in advance with base order
- Cache rest calls during same loop iteration
- Introduce testnet for bybit orders (should work with real net for WS api), useful to test new feature
dca feature must be enabled with "DCA_TYPE=DCA_AVERAGE_ENTRIES" and allows to place additional DCA_SAFETY_ORDERS, as limits orders. The position size fro any additional order is scaled by DCA_VOLUME_SCALE and the price deviation for any orders is DCA_PRICE_DEVIATION_PRC. Unfilled limit orders ore handles when the trade will be closed and also after in the main loop a routine perform a consistency check and remove orphan orders. WARNING: This an experimental feature, play with it at your own risk.
…nd multiple scalp enqueued
set PAUSED_LIST in config when you want to set a custom take profit manually, for example directy from the exchange ui. PAUSED token will be normally tracked but tp ad sl won't be recalculated.
Now liquidity_trigger store only liquidation value that happen on a specific dca order without considering past liquidation value. Past liquidation value are tracked anyway by previous log occurring on previous DCA order.
Settings was not synched with minOrderSize update
avoid to perform the same rest api call many times in the same main loop
require the api for testnet account require a real api key to receive liquidation info
Remove orphan order handling from main loop as sometimes happens that new order is placed but not available by bybit api and new order are prematurely cancelled. Orphan order are handled only at start and when the order is closed.
Settings files are created during execution and should be removed from repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.