Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TokenItemAdding to invoke even if data is not string #525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaismic
Copy link

@kaismic kaismic commented Oct 6, 2024

Fixes #529

PR Type

What kind of change does this PR introduce?

Other: Feature added

What is the current behavior?

See issue #5006

What is the new behavior?

See issue #5006

PR Checklist

Please check if your PR fulfills the following requirements:

  • [o] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • [o] Based off latest main branch of toolkit
  • [o] Tested code with current supported SDKs
  • [o] Contains NO breaking changes

Other information

@kaismic
Copy link
Author

kaismic commented Oct 6, 2024

@dotnet-policy-service agree

@kaismic kaismic changed the title now TokenItemAdding invokes even if data is not string Allow TokenItemAdding to invoke even if data is not string Oct 6, 2024
@michael-hawker michael-hawker self-requested a review November 5, 2024 17:53
@michael-hawker michael-hawker self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
2 participants