Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block on mentored code review #1240

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Add block on mentored code review #1240

merged 8 commits into from
Dec 18, 2024

Conversation

illicitonion
Copy link
Member

What does this change?

Add block on mentored code review

Common Content?

  • Creates common-content/en/blocks/mentored-code-review/index.md (currently unreferenced)

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit e12dbb4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6761ea7a7dbb640008292233
😎 Deploy Preview https://deploy-preview-1240--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit e12dbb4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6761ea7a2a667d0008d0bf73

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit e12dbb4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6761ea7a264fe70008375a29
😎 Deploy Preview https://deploy-preview-1240--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit e12dbb4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6761ea7a21a10400085c616d
😎 Deploy Preview https://deploy-preview-1240--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit e12dbb4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6761ea7ae6053b00088de0b7
😎 Deploy Preview https://deploy-preview-1240--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit e12dbb4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6761ea7a2a667d0008d0bf79
😎 Deploy Preview https://deploy-preview-1240--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit e12dbb4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6761ea7ae29f3100080380a1
😎 Deploy Preview https://deploy-preview-1240--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit e12dbb4
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6761ea7ad154b10008aca79b
😎 Deploy Preview https://deploy-preview-1240--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I'll open my giant PR at lunch

common-content/en/blocks/mentored-code-review/index.md Outdated Show resolved Hide resolved
common-content/en/blocks/mentored-code-review/index.md Outdated Show resolved Hide resolved
common-content/en/blocks/mentored-code-review/index.md Outdated Show resolved Hide resolved
common-content/en/blocks/mentored-code-review/index.md Outdated Show resolved Hide resolved
common-content/en/blocks/mentored-code-review/index.md Outdated Show resolved Hide resolved
@SallyMcGrath SallyMcGrath mentioned this pull request Dec 10, 2024
14 tasks
@SallyMcGrath SallyMcGrath self-requested a review December 17, 2024 21:17
@illicitonion illicitonion merged commit 6fc9943 into main Dec 18, 2024
34 checks passed
@illicitonion illicitonion deleted the mentored-code-review branch December 18, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants