Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Add service_bd_routing_disable attribute to aci_bridge_domain resource and datasource (DCNE-263) #1305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[minor_change] Add service_bd_routing_disable attribute to aci_bridge_domain resource and datasource (DCNE-263) #1305

wants to merge 1 commit into from

Conversation

akinross
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.45%. Comparing base (7ecea9c) to head (14debd3).

Files with missing lines Patch % Lines
internal/provider/resource_aci_bridge_domain.go 65.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
- Coverage   85.45%   85.45%   -0.01%     
==========================================
  Files         125      125              
  Lines       70689    70713      +24     
==========================================
+ Hits        60409    60429      +20     
- Misses       8324     8327       +3     
- Partials     1956     1957       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sajagana
sajagana previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib added the jira-sync Sync this issue to Jira label Dec 3, 2024
@github-actions github-actions bot changed the title [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) (DCNE-264) Dec 3, 2024
@samiib samiib removed the jira-sync Sync this issue to Jira label Dec 3, 2024
@samiib samiib changed the title [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) (DCNE-264) [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) Dec 3, 2024
gmicol
gmicol previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross dismissed stale reviews from gmicol, samiib, shrsr, and sajagana via 14debd3 December 19, 2024 08:01
@akinross akinross force-pushed the 1304_missing_atttributes_aci_bridge_domain branch from c56a6ff to 14debd3 Compare December 19, 2024 08:01
@akinross akinross changed the title [ignore] Fix conflict paths and set correct attribute naming for relay_policy and netflow_monitor_policy relationship in bridge_domain (DCNE-263) [minor_change] Add service_bd_routing_disable attribute to aci_bridge_domain resource and datasource (DCNE-263) Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol left review comments

@samiib samiib samiib left review comments

@sajagana sajagana sajagana left review comments

@shrsr shrsr shrsr left review comments

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akinross @codecov-commenter @shrsr @sajagana @samiib @gmicol