Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug_fix] Updated README to match RedHat's ansible collection template (DCNE-198) #692

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[bug_fix] Updated README to match RedHat's ansible collection template (DCNE-198) #692

merged 1 commit into from
Oct 28, 2024

Conversation

samiib
Copy link
Collaborator

@samiib samiib commented Oct 11, 2024 •
edited
Loading

Readme should match this template https://access.redhat.com/articles/7068606

@samiib samiib self-assigned this Oct 11, 2024
@samiib samiib added the documentation Improvements or additions to documentation label Oct 11, 2024
@samiib samiib marked this pull request as ready for review October 14, 2024 09:53
akinross
akinross requested changes Oct 14, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@samiib samiib requested a review from akinross October 15, 2024 05:49
akinross
akinross previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross
Copy link
Collaborator

Should we add a link to the following page https://github.com/shrsr/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_modules_general_aci.rst?

@samiib
Copy link
Collaborator Author

samiib commented Oct 16, 2024

Should we add a link to the following page https://github.com/shrsr/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_modules_general_aci.rst?

@akinross I think this is a really great documentation, we should add to the wiki of this repo or as another markdown in this repo.

@akinross
Copy link
Collaborator

Should we add a link to the following page https://github.com/shrsr/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_modules_general_aci.rst?

@akinross I think this is a really great documentation, we should add to the wiki of this repo or as another markdown in this repo.

Yes this is written by @shrsr a long time ago but should have been included in the repo. I now have had multiple occasions where people wanting to contribute were not aware so think we should be more vocal about this. #278 is actually sort of tracking it already I think

shrsr
shrsr previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot requested changes Oct 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@samiib samiib dismissed stale reviews from shrsr, gmicol, and akinross via 1d4ab9d October 18, 2024 13:06
anvitha-jain
anvitha-jain requested changes Oct 18, 2024
View reviewed changes
README.md Show resolved Hide resolved
@samiib samiib requested a review from anvitha-jain October 22, 2024 13:08
akinross
akinross previously approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Oct 24, 2024
View reviewed changes
shrsr
shrsr requested changes Oct 24, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@samiib samiib dismissed stale reviews from anvitha-jain and akinross via 57f137a October 24, 2024 22:36
sajagana
sajagana approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit e7c78a0 into CiscoDevNet:master Oct 28, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajagana sajagana sajagana approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

Assignees

@samiib samiib

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@samiib @akinross @lhercot @shrsr @anvitha-jain @sajagana @gmicol