enhancement for node_mgmt_epg_to_contract (DCNE-87) #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
lhercot,
shrsr,
akinross,
sajagana,
samiib,
gmicol and
anvitha-jain
github-actions
bot
changed the title
Ziaf007
force-pushed
the
node_mgmt_epg_to_contract
branch
from
9010dbf to
820f4cc
Compare
Ziaf007
force-pushed
the
node_mgmt_epg_to_contract
branch
from
820f4cc to
2873077
Compare
samiib
requested changes
Oct 25, 2024
| argument_spec.update(aci_annotation_spec()) | ||
| argument_spec.update( | ||
| contract_type=dict(type="str", choices=["consumer", "provider", "taboo", "interface"], required=True), | ||
| epg_type=dict(type="str", aliases=["type"], choices=["in_band","out_of_band"], required=True) |
There was a problem hiding this comment.
Suggested change
| epg_type=dict(type="str", aliases=["type"], choices=["in_band","out_of_band"], required=True) | |
| epg_type=dict(type="str", aliases=["type"], choices=["in_band","out_of_band"], required=True), |
This should fix the black formatting error. Please run black -l 159 to format this one.
…ontract.url does not exist remain
akinross
requested changes
Dec 17, 2024
Comment on lines
+4
to
+5
| # Copyright: (c) 2017, Jacob McGill (@jmcgill298) | ||
| # Copyright: (c) 2023, Akini Ross (@akinross) <[email protected]> |
| argument_spec = aci_argument_spec() | ||
| argument_spec.update(aci_annotation_spec()) | ||
| argument_spec.update( | ||
| contract_type=dict(type="str", choices=["consumer", "provider", "taboo", "interface"], required=True), |
There was a problem hiding this comment.
docs do not match [ consumer, provider, taboo, interface, intra_epg ]
Comment on lines
+89
to
+90
| - Jacob McGill (@jmcgill298) | ||
| - Akini Ross (@akinross) |
|
|
||
| DOCUMENTATION = r""" | ||
| --- | ||
| module: aci_epg_to_contract |
| module: aci_epg_to_contract | ||
| short_description: Bind EPGs to Contracts (fv:RsCons, fv:RsProv, fv:RsProtBy, fv:RsConsIf, and fv:RsIntraEpg) | ||
| description: | ||
| - Bind EPGs to Contracts on Cisco ACI fabrics. |
There was a problem hiding this comment.
specific to magement node
| class_config = {"prio": priority, aci_name: contract} | ||
|
|
||
| if contract_type != "provider": | ||
| module.fail_json(msg="out_of_band EPG only supports Provider contract attachment.") |
There was a problem hiding this comment.
Suggested change
| module.fail_json(msg="out_of_band EPG only supports Provider contract attachment.") | |
| module.fail_json(msg="only 'provider' contract_type is supported for 'out_of_band' epg_type") |
Comment on lines
+311
to
+333
| root_class=dict( | ||
| aci_class="fvTenant", | ||
| aci_rn="tn-mgmt", | ||
| module_object="mgmt", | ||
| target_filter={"name": "mgmt"}, | ||
| ), | ||
| subclass_1=dict( | ||
| aci_class="mgmtMgmtP", | ||
| aci_rn="mgmtp-default", | ||
| module_object="default", | ||
| target_filter={"name": "default"}, | ||
| ), | ||
| subclass_2=dict( | ||
| aci_class=class_Map[epg_type][0]["epg_class"], | ||
| aci_rn=class_Map[epg_type][0]["epg_rn"].format(epg), | ||
| module_object=epg, | ||
| target_filter={"name": epg}, | ||
| ), | ||
| subclass_3=dict( | ||
| aci_class=aci_class, | ||
| aci_rn="{0}{1}".format(aci_rn, contract), | ||
| module_object=contract, | ||
| target_filter={aci_name: contract}, |
There was a problem hiding this comment.
is class query working? else try adding rootclass /subclass1/2 together since they are static values
| aci.get_existing() | ||
|
|
||
| if state == "present": | ||
| child_configs = [] |
There was a problem hiding this comment.
why define child_configs here as []?
| # Test code for the ACI modules | ||
| # Copyright: (c) 2024, Faiz Mohammad (@faizmoh) <[email protected]> | ||
|
|
||
| # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt) |
There was a problem hiding this comment.
can you convert to this format: https://github.com/CiscoDevNet/ansible-aci/blob/master/tests/integration/targets/aci_esg_to_contract/tasks/main.yml
| state: present | ||
|
|
||
| # CREATE INB | ||
| - name: bind inb contract to inband epg - check mode works |
There was a problem hiding this comment.
assert defaults and test all attributes can be updates that can be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-) Added node_mgmt_epg_to_contract module
-) Test.yml still pending, working on it.
DCNE-87