Initial WebXR display support for Scene

.github/actions/check-for-CLA/index.js

@@ -32,7 +32,7 @@ const main = async () => {
 
   const response = await postCommentOnPullRequest(
     hasSignedCLA,
-    errorFoundOnCLACheck
+    errorFoundOnCLACheck,
   );
 };
 
@@ -49,7 +49,7 @@ const checkIfUserHasSignedAnyCLA = async () => {
 const checkIfIndividualCLAFound = async () => {
   const response = await getValuesFromGoogleSheet(
     GOOGLE_SHEETS_INFO.individualCLASheetId,
-    "D2:D"
+    "D2:D",
   );
 
   const rows = response.data.values;
@@ -70,7 +70,7 @@ const checkIfIndividualCLAFound = async () => {
 const checkIfCorporateCLAFound = async () => {
   const response = await getValuesFromGoogleSheet(
     GOOGLE_SHEETS_INFO.corporateCLASheetId,
-    "H2:H"
+    "H2:H",
   );
 
   const rows = response.data.values;
@@ -132,14 +132,14 @@ const postCommentOnPullRequest = async (hasSignedCLA, errorFoundOnCLACheck) => {
         accept: "application/vnd.github+json",
         "X-GitHub-Api-Version": "2022-11-28",
       },
-    }
+    },
   );
 };
 
 const getCommentBody = (hasSignedCLA, errorFoundOnCLACheck) => {
   const commentTemplate = fs.readFileSync(
     "./.github/actions/check-for-CLA/templates/pullRequestComment.hbs",
-    "utf-8"
+    "utf-8",
   );
 
   const getCommentFromTemplate = Handlebars.compile(commentTemplate);

.github/workflows/cla.yml

@@ -16,12 +16,12 @@ jobs:
         with:
           node-version: '20'
       - name: install npm packages
-        run: npm install googleapis @octokit/core handlebars fs-extra        
+        run: npm install googleapis @octokit/core handlebars fs-extra
       - name: run script
         run: node .github/actions/check-for-CLA/index.js
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          PULL_REQUEST_ID: ${{ github.event.number }}      
+          PULL_REQUEST_ID: ${{ github.event.number }}
           GOOGLE_KEYS: ${{ secrets.GOOGLE_KEYS }}
-          INDIVIDUAL_CLA_SHEET_ID: ${{ secrets.INDIVIDUAL_CLA_SHEET_ID }}  
-          CORPORATE_CLA_SHEET_ID: ${{ secrets.CORPORATE_CLA_SHEET_ID }}  
+          INDIVIDUAL_CLA_SHEET_ID: ${{ secrets.INDIVIDUAL_CLA_SHEET_ID }}
+          CORPORATE_CLA_SHEET_ID: ${{ secrets.CORPORATE_CLA_SHEET_ID }}

.gitignore

@@ -42,4 +42,4 @@ yarn.lock
 .idea/shelf
 
 # Used in the CLA checking GitHub workflow
-GoogleConfig.json
+GoogleConfig.json

CHANGES.md

@@ -54,7 +54,6 @@
 
 ##### Additions :tada:
 
-- Added `HeightReference.CLAMP_TO_TERRAIN`, `HeightReference.RELATIVE_TO_TERRAIN`, `HeightReference.CLAMP_TO_3D_TILE`, and `HeightReference.RELATIVE_TO_3D_TILE` to position relatve to terrain or 3D tilesets exclusively.[#11604](https://github.com/CesiumGS/cesium/pull/11604)
 - Added `Cesium3DTileset.getHeight` to sample height values of the loaded tiles. If using WebGL 1, the `enablePick` option must be set to true to use this function. [#11581](https://github.com/CesiumGS/cesium/pull/11581)
 - Added `Cesium3DTileset.disableCollision` to allow the camera from to go inside or below a 3D tileset, for instance, to be used with 3D Tiles interiors. [#11581](https://github.com/CesiumGS/cesium/pull/11581)
 - Fog rendering now applies to glTF models and 3D Tiles. This can be configured using `scene.fog` and `scene.atmosphere`. [#11744](https://github.com/CesiumGS/cesium/pull/11744)
@@ -335,6 +334,7 @@ try {
 ##### Additions :tada:
 
 - Added `Cesium3DTileset.cacheBytes` and `Cesium3DTileset.maximumCacheOverflowBytes` to better control memory usage. To replicate previous behavior, convert `maximumMemoryUsage` from MB to bytes, assign the value to `cacheBytes`, and set `maximumCacheOverflowBytes = Number.MAX_VALUE`
+- Added `Cesium.Scene.webXRContext` and initial support for integrating Cesium into the WebXR redering cycle.
 
 ##### Fixes :wrench:
 
@@ -1968,7 +1968,7 @@ _This is an npm-only release to fix a publishing issue_.
   - This is to make clipping planes' coordinates always relative to the object they're attached to. So if you were positioning the clipping planes as in the example below, this is no longer necessary:
   ```javascript
   clippingPlanes.modelMatrix = Cesium.Transforms.eastNorthUpToFixedFrame(
-    tileset.boundingSphere.center
+    tileset.boundingSphere.center,
   );
   ```
   - This also fixes several issues with clipping planes not using the correct transform for tilesets with children.

CONTRIBUTORS.md

@@ -381,3 +381,4 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
 - [Harsh Lakhara](https://github.com/harshlakhara)
 - [Pavlo Skakun](https://github.com/p-skakun)
 - [Taylor Huffman](https://github.com/huffmantayler)
+- [Arturo Espinosa Aldama](https://github.com/pupitetris)

package.json

@@ -160,4 +160,4 @@
     "packages/engine",
     "packages/widgets"
   ]
-}
+}

packages/engine/Source/Core/PerspectiveOffCenterFrustum.js

@@ -92,6 +92,50 @@ function PerspectiveOffCenterFrustum(options) {
   this._infinitePerspective = new Matrix4();
 }
 
+/**
+ * Obtains a PerspectiveOffCenterFrustum from a projection matrix.
+ *
+ * @param {Matrix4} projectionMatrix The matrix representing the projection tranformation.
+ * @param {PerspectiveOffCenterFrustum} [result] The object into which to store the result.
+ * @returns {PerspectiveOffCenterFrustum} The modified result parameter or a new PerspectiveOffCenterFrustum instance if one was not provided.
+ */
+PerspectiveOffCenterFrustum.fromProjectionMatrix = function (
+  projectionMatrix,
+  result
+) {
+  if (!defined(result)) {
+    result = new PerspectiveOffCenterFrustum();
+  }
+
+  const near =
+    projectionMatrix[Matrix4.COLUMN3ROW2] /
+    (projectionMatrix[Matrix4.COLUMN2ROW2] - 1);
+
+  result.near = near;
+
+  result.far =
+    projectionMatrix[Matrix4.COLUMN3ROW2] /
+    (1 + projectionMatrix[Matrix4.COLUMN2ROW2]);
+
+  result.right =
+    (near * (1 + projectionMatrix[Matrix4.COLUMN2ROW0])) /
+    projectionMatrix[Matrix4.COLUMN0ROW0];
+
+  result.left =
+    (near * (projectionMatrix[Matrix4.COLUMN2ROW0] - 1)) /
+    projectionMatrix[Matrix4.COLUMN0ROW0];
+
+  result.top =
+    (near * (1 + projectionMatrix[Matrix4.COLUMN2ROW1])) /
+    projectionMatrix[Matrix4.COLUMN1ROW1];
+
+  result.bottom =
+    (near * (projectionMatrix[Matrix4.COLUMN2ROW1] - 1)) /
+    projectionMatrix[Matrix4.COLUMN1ROW1];
+
+  return result;
+};
+
 function update(frustum) {
   //>>includeStart('debug', pragmas.debug);
   if (