Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support window build #35

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Support window build #35

wants to merge 24 commits into from

Conversation

baothientran
Copy link
Contributor

Fixes #17

  • Downgrade GDAL to 2.4.1 to be compatible with GDAL in vcpkg.
  • Change Math.h file to MathUtility.h since window mistakes the file with the standard header #include<math.h>
  • Explicitly convert std::filesystem::path to std::string since on Window, std::filesystem::path seems to implicitly convert to std::wstring instead of std::string like gcc
  • Remove OSG::JPEG plugin since we never use it
  • Update instruction to compile on Window in the README file

@baothientran baothientran changed the title Window build Support window build Nov 30, 2020
@lilleyse
Copy link
Contributor

lilleyse commented Dec 2, 2020

@baothientran the code and README updates look good at a quick glance.

One thing - there are some files with a bunch of whitespace changes in the diff, looks like spaces were converted to tabs accidentally. Once that's fixed @likangning93 can do a final review and merge.

@baothientran
Copy link
Contributor Author

@likangning93 @lilleyse I update the whitespace format in the new commit. It is ready for another review

@lilleyse
Copy link
Contributor

Offline we talked about using conan which may fix the the GDAL issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support window build
2 participants