-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support window build #35
base: main
Are you sure you want to change the base?
Conversation
@baothientran the code and README updates look good at a quick glance. One thing - there are some files with a bunch of whitespace changes in the diff, looks like spaces were converted to tabs accidentally. Once that's fixed @likangning93 can do a final review and merge. |
@likangning93 @lilleyse I update the whitespace format in the new commit. It is ready for another review |
Offline we talked about using conan which may fix the the GDAL issues |
Fixes #17
Math.h
file toMathUtility.h
since window mistakes the file with the standard header#include<math.h>
std::filesystem::path
tostd::string
since on Window,std::filesystem::path
seems to implicitly convert tostd::wstring
instead ofstd::string
like gcc