Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used some flake8 rules to clean up the code a bit more #73

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

marksmayo
Copy link
Contributor

Used flake8 to identify some issues

Style and cleanliness change

  • [X ] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [X ] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my own code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [X ] I have made corresponding changes to the documentation
  • [X ] My changes generate no new warnings
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [NA ] New and existing unit tests pass locally with my changes (not just the CI)
  • [NA ] Any dependent changes have been merged and published in downstream modules
  • [NA ] I have labeled my PR using appropriate tags (in particular using status labels like Status: Code Review Needed, Business: Test Needed or Status: In Progress if you are still working on the PR)

Do not forget to @ the people that needs to do the review

marksmayo and others added 7 commits December 7, 2022 16:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@marksmayo
Copy link
Contributor Author

It looks like when I pulled, I got a new setup.py and it's having issues install?

@js-dieu
Copy link
Collaborator

js-dieu commented Jul 10, 2023

Hello! Thanks for reaching out!
I started some clean up and alignment with new python standards. As setuptools is being deprecated, the pyproject.toml is the new de facto way of doing.
Have you tried the following (run it under pytest-monitor root folder)

For development purpose:
python -m pip install -e .

For simple install:
python -m pip install .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants