-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add evaluation status bar item #480
Closed
stefan-toubia
wants to merge
1
commit into
BetterThanTomorrow:dev
from
stefan-toubia:wip/eval-status
+114
−4
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
|
||
import * as vscode from 'vscode'; | ||
|
||
export interface TextIncrementor { | ||
next(): string; | ||
reset(): void; | ||
} | ||
|
||
export class Incrementor { | ||
constructor( | ||
private start: number, | ||
private end: number | ||
) { | ||
this._val = start; | ||
} | ||
private _val: number; | ||
|
||
next() { | ||
if(this._val > this.end) { | ||
this._val = this.start; | ||
} | ||
return this._val++; | ||
} | ||
reset = () => this._val = this.start; | ||
} | ||
|
||
export class StatusBarAnimator { | ||
constructor( | ||
private incrementor: TextIncrementor, | ||
private interval: number | ||
) { } | ||
timer: NodeJS.Timer; | ||
|
||
start(sbi: vscode.StatusBarItem) { | ||
this.incrementor.reset(); | ||
this.timer = setInterval( | ||
() => sbi.text = this.incrementor.next(), | ||
this.interval | ||
); | ||
} | ||
stop = () => clearInterval(this.timer); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was recently added, I'm not familiar with the purpose. Would it make sense for this to also be represented in the status bar indicator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be from @cfehse 's fix for the load file callback. And yes, would probably be material for a status indicator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose was solely to show that an error occurred instead of ignoring the error condition completely.