Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist user selected theme and load initially #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

g7i
Copy link
Contributor

@g7i g7i commented Oct 8, 2022

Please check the attached video.

Persist.theme-1.mov

@Rajkumar-justcoder
Copy link
Member

Rajkumar-justcoder commented Oct 8, 2022

as on the video i can see that why u are we are setting dark theme as default then after that u are below setting theme which is saved in locally
so here u can see that there is flicker in the theme when page is load or reload so it would be better that first if theme is not set to local storage then set time and change theme if it it set in local storage then just direct set theme on site

@Rajkumar-justcoder
Copy link
Member

as code just run after that set items so it just

@g7i
Copy link
Contributor Author

g7i commented Oct 8, 2022

@Rajkumar-justcoder Didn't catch your comment, but if you meant to fix the flickering I have fixed it.

@Rajkumar-justcoder
Copy link
Member

@Rajkumar-justcoder Didn't catch your comment, but if you meant to fix the flickering I have fixed it.

wat do hack

@Rajkumar-justcoder
Copy link
Member

hmm now i guess looks good 😸
trying it after merge
can u provide videos again so i can merge without hazzel

@Rajkumar-justcoder
Copy link
Member

hey also that ig we have removed template card from code so as u have add -1 to the number of the contribution so far it incruate

Copy link

@beaubeas beaubeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants