tag inheritance solution fixed #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2024 10:29
… the rg and resources in the rg
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 01dd95f. |
TonyWildish-BH
requested changes
Dec 16, 2024
There was a problem hiding this comment.
sorry for the delay on this, there are a few minor things that still need fixing, please.
- this PR still has unwanted changes to
config.sample.yaml. doit-all.shandonly-the-good-bits.shhave been committed again.- in
templates/workspace_services/azuresql/terraform/locals.tf, a blank line has been deleted, at line 4. Can we try not to make whitespace changes that don't impact the behaviour, it keeps our code better in sync with the upstream.
P.S. rather than create a new PR, you can just commit the code on this branch, and the PR will be updated automatically. That should make things easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tag inheritance solution fixed