Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Inheritance solution #214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tag Inheritance solution #214

wants to merge 1 commit into from

Conversation

BIOKU-BH
Copy link

Tag Inheritance Solution

Copy link

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 83e6ea3.

Copy link
Collaborator

@TonyWildish-BH TonyWildish-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the base-adf workspace, I see updates to parameters.json, porter.yaml, template_schema.json, terraform/locals.tf, and terraform/variables.tf. These all look good to me.

For the base workspace, there's no update to terraform/locals.tf, is that correct?

For the unrestricted workspace, there's no update to either the locals.tf or variables.tf file, is that correct?

I would expect that all the workspace templates would need the same set of changes, can you confirm that this PR is complete?

@BIOKU-BH
Copy link
Author

The unrestricted template does not have any terraform file in it. Just the json files and the portal.yaml file, hence the reason

@TonyWildish-BH
Copy link
Collaborator

The unrestricted template does not have any terraform file in it. Just the json files and the portal.yaml file, hence the reason

Thanks. What about the base template, is there no update needed for the locals.tf?

@BIOKU-BH
Copy link
Author

The Lint is also still throwing another kind of error... Will try to fix that too

@BIOKU-BH
Copy link
Author

There is ... weirdo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants