-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace name as Tag #211
base: main
Are you sure you want to change the base?
Conversation
… the rg and resources in the rg
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 01dd95f. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things that need fixing:
config.sample.yaml
has vanished, it should be restored, please.doit-all.sh
andonly-the-good-bits.sh
shouldn't be committed, these are our private scripts, let's keep them out of the code base here. They're in thetre-tools
repo, I think.- can you please also propagate these changes to the other workspace templates. We definitely need the base+adf template to be updated, since this is the one we'll use by default, but we also want the others to be consistent with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Bioku. I'm not sure what's going on, but I no longer see the changes to the base workspace, just the base+adf and unrestricted. I thought the base workspace was there already?
Also, I think it still isn't correct that config.sample.yaml
is now showing as having been added. Can you revert the commit, or something, so it was never deleted in the first place?
Thanks, I can fix this. I might need to fetch the status of the head and that would fix the issues except the lint one. regarding the lint, I will investigate it and fix it. |
What is being addressed
Baked the workspace name into the schema and further used it as tag on the rg and resources in the rg
How is this addressed
-Collect the workspace name