Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace name as Tag #211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Workspace name as Tag #211

wants to merge 2 commits into from

Conversation

BIOKU-BH
Copy link

What is being addressed

Baked the workspace name into the schema and further used it as tag on the rg and resources in the rg

How is this addressed

-Collect the workspace name

@BIOKU-BH BIOKU-BH linked an issue Dec 10, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 10, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 01dd95f.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@TonyWildish-BH TonyWildish-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things that need fixing:

  • config.sample.yaml has vanished, it should be restored, please.
  • doit-all.sh and only-the-good-bits.sh shouldn't be committed, these are our private scripts, let's keep them out of the code base here. They're in the tre-tools repo, I think.
  • can you please also propagate these changes to the other workspace templates. We definitely need the base+adf template to be updated, since this is the one we'll use by default, but we also want the others to be consistent with this.

Copy link
Collaborator

@TonyWildish-BH TonyWildish-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bioku. I'm not sure what's going on, but I no longer see the changes to the base workspace, just the base+adf and unrestricted. I thought the base workspace was there already?

Also, I think it still isn't correct that config.sample.yaml is now showing as having been added. Can you revert the commit, or something, so it was never deleted in the first place?

@BIOKU-BH
Copy link
Author

Thanks, I can fix this.

I might need to fetch the status of the head and that would fix the issues except the lint one.

regarding the lint, I will investigate it and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test Issue
2 participants