Upstream refresh #142
Merged
Upstream refresh #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results632 tests 630 ✅ 9s ⏱️ Results for commit ef95419. |
akolensky
approved these changes
Aug 22, 2024
|
I will take a look at this today and communicate my findings if any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #127
What is being addressed
This merge request pulls in the latest changes from the upstream branch as of about a week ago.
How is this addressed
There are a lot of changes here, I'm not expecting you to review them all. I've tested them, and Andrii has tested them.
The only known problem is with the Nexus machine hanging, but that happens in the upstream, it's not just us. I've tried enlarging the Nexus VM disk by hand, and after a bit of flakiness, it's now been working without problem for a few days. Not sure if that's the full resolution or not, TBD.
I've tested the airlock, that functions correctly. I've tested RStudio, Jupyter, Azure Storage Explorer, all on Linux, and that works.
Please take a (quick) look, and approve so we can get the merge.