-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set target sdk and compile sdk to34 #1747
Open
somalaya
wants to merge
8
commits into
dev
Choose a base branch
from
somalaya/setTargetSDKAndCompileSDKTo34
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
somalaya
commented
Jul 26, 2023
•
edited
Loading
edited
- Increasing the targetSDK and compileSDK to 34
- After increasing the targetSDK, it gave some errors like exported attribute must be added when there is an intent filter. So I added that.
- PowerliftSDK version to the latest '1.0.3' as this one has fixes for target and compile sdk to be 34.
* updated versions.properties, build.gradle & changeLog * changed RC1 to RC3 as RC1 and RC2 are already pushed in Jul 2022 * updated common to RC2 * version changed to 4.7.0 * updated to RC3 * removed RC tags * updated changeLog, version.props and buildGradle
somalaya
changed the title
Somalaya/set target sdk and compile sdk to34
Set target sdk and compile sdk to34
Jul 26, 2023
shahzaibj
approved these changes
Jul 26, 2023
p3dr0rv
approved these changes
Jul 27, 2023
somalaya
force-pushed
the
somalaya/setTargetSDKAndCompileSDKTo34
branch
from
August 4, 2023 18:15
b1da49a
to
21ca27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.