Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[advisor] Migrate @azure/arm-advisor with @azure/dev-tool additions #32283

Merged
merged 123 commits into from
Dec 18, 2024

Conversation

mpodwysocki
Copy link
Member

@mpodwysocki mpodwysocki commented Dec 18, 2024

Packages impacted by this PR

  • @azure/dev-tool
  • @azure/arm-advisor
  • @azure/arm-agrifood
  • @azure/arm-apicenter

Issues associated with this PR

Describe the problem that is addressed by this PR

Migrates @azure/arm-advisor to ESM/vitest via @azure/dev-tool and adds fixes such as vi.fn() support and import "dotenv/config";

Also adds support for ESM testing and type testing.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@jeremymeng jeremymeng merged commit 25f960a into main Dec 18, 2024
14 checks passed
@jeremymeng jeremymeng deleted the feat/arm-advisor-esm branch December 18, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants