Update API version to 2024-09-01-preview #14261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyjain358
approved these changes
Dec 17, 2024
| @@ -3,7 +3,7 @@ | |||
| "contentVersion": "1.0.0.0", | |||
| "parameters": { | |||
| "apiVersion": { | |||
| "value": "2024-04-01" | |||
| "value": "2024-09-01-preview" | |||
There was a problem hiding this comment.
API Versions should not be parameterized. Can this (and other instances of this) parameter be removed, and the API version can be hardcoded?
There was a problem hiding this comment.
We have used API version in the parameters to allow extensibility to the customers.
If we remove this api version now, this would mean a breaking change for consumers at this point.
Would be to possible to allow us take in this in a planned manner in future iterations ?
alex-frankel
requested changes
Dec 17, 2024
azure-quickstarts
added
manual validation required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Check these items before submitting a PR...
Contribution Guide
Best Practice Guide
Changelog