-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NFT Trading bridge #305
Open
liusanchuan
wants to merge
29
commits into
AztecProtocol:master
Choose a base branch
from
liusanchuan:nft-trading-bridge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refers to: https://github.com/critesjosh/aztec-connect-starter/tree/nft-bridge Kudo to this guy.
Refers to: https://github.com/critesjosh/aztec-connect-starter/tree/nft-bridge Kudo to this guy.
* style: updated formatting * fix: Bump liquity gas bounds Co-authored-by: LHerskind <[email protected]>
* feat: add element deployment + update workaround * fix: remapping + clarity improvement data provider deployment * fix: formatting * fix: Add missing broadcast in element deployment s * fix: we be formatting Co-authored-by: cheethas <[email protected]>
* feat: listing erc4626 subsidies * feat: finished listing erc4626 subsidies * feat: yearn subsidy listing + list all flag * feat: ERC4626 tags * feat: displaying cost estimation for a month * refactor: improved naming * feat: getting info from env * fix: use log instead of list * fix: spelling * fix: use decimals for easier read * fix: print constants used Co-authored-by: LHerskind <[email protected]>
…ztec-Opensea-bridges into nft-trading-bridge
Refers to: https://github.com/critesjosh/aztec-connect-starter/tree/nft-bridge Kudo to this guy.
…ztec-Opensea-bridges into nft-trading-bridge
…ztec-Opensea-bridges into nft-trading-bridge
…ztec-Opensea-bridges into nft-trading-bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the Specs of My NFT trading bridge.
Checklist:
forge coverage --match-contract MyContract
returns 100% line coverage.