Fix KnownFolder for x86 Windows #17705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
added
bug
os-windows
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
Alexizx00789999
approved these changes
Dec 15, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Fix KnownFolder for x86 Windows * Remove try-finally
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes an
AccessViolationExceptionwhenStorageProvider.TryGetWellKnownFolderAsync(WellKnownFolder.Downloads)is called on Windows x86.What is the current behavior?
AccessViolationExceptionon Windows x86, works on Windows x64. Unknown on Windows ARM.What is the updated/expected behavior with this PR?
Works on Windows x86/x64. Untested on Windows ARM (no device to test with).
How was the solution implemented (if it's not obvious)?
Eliminate
MarshalAs(UnmanagedType.LPStruct)] Guidin favor ofGuid*. Suspect some marshaling difference is at play and prefer the directly blittable type.Thanks to @tannergooding for guidance and overall style cleanups.
Removed try-finally as there aren't any exceptions to handle -- prototype version used an early return.
Checklist
Fixed issues
Fixes #17679