Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate option for bridging mcast and hw can #28913

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bugobliterator
Copy link
Member

@bugobliterator bugobliterator commented Dec 20, 2024

  • Bridging between mcast CAN and HW CAN needs to be turned off by default. The reason is if there are more than 2 devices on the same HW CAN and Ethernet network that will cause network loops and potentially choke the CAN bus.
  • Bridging needs to be always turned off for Bootloaders, and in the case of AP_Periph and ardupilot, it should be enabled by the user.

Changes done:

  • Change option name from CAN1_MCAST_GATEWAY to CAN1_MCAST_ENDPOINT in NET_OPTIONS.
  • Adds another option CAN1_MCAST_BRIDGED to enable bridging between MCAST and Hw CAN.
  • Bridging option can be changed and will take effect on the same run, reboot is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants