AP_GPS: handle switching for more than 2 gpses #28908
Open
+46
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of instantly switching after finding a better gps, check all gpses then perform a switch to ensure there isn't any other better gps
|
Nice! Looks reasonable. How'd you test the changes? |
I haven't personally tested the changes yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of instantly switching after finding a better GPS, check all GPSes first then switch to ensure there isn't any other better GPS, This will only improve performance on setups with more than 2 GPSes, This commit also changes the behavior of status lock switches, previously they switched without any timeouts, in the new code the 5000ms timeout applies to them as well.