Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: log whether throttle is suppressed or not #28906

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

This adds logging of whether the throttle is suppressed or not into the STAT message.

I've created a new field, "Bit" to hold a bitmask of boolean information about the vehicle - saves 40 bytes per message past me adding the new field.

I suggest we remove the old equivalent uint8_t fields in 4.8 - just have them in here for a bit of cross-over.

The new LogStatus class is perhaps overkill - but I think we might be able to templatise it and have a nice, compact way of doing similar bitmasks in log messages.

For this entire PR:

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
CubeRedPrimary                      *      *           *       *                 120    *      *
Durandal                            *      *           *       *                 72     *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 120    *      *
MatekF405                           *      *           *       *                 120    *      *
Pixhawk1-1M-bdshot                  *                  *       *                 120    *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 120    *      *
skyviper-journey                                       *                                       
skyviper-v2450                                         *                                       

Without the new logging, just with the weird class and consolidating into status, removing the old fields:

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
CubeRedPrimary                      *      *           *       *                 -32    *      *
Durandal                            *      *           *       *                 -24    *      *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 -32    *      *
MatekF405                           *      *           *       *                 -32    *      *
Pixhawk1-1M-bdshot                  *                  *       *                 -32    *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 -32    *      *
skyviper-journey                                       *                                       
skyviper-v2450                                         *                                       

@Georacer
Copy link
Contributor

I like the idea of a more compact logging of logic flags. Smaller logs is always better.

But as it stands, it would make reading the logs (e.g. via MAVExplorer) much harder.
How do you propose decoding the new status field to extract and plot individual bits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants