Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Merged all offline functions in one module. #198

Closed
wants to merge 3 commits into from

Conversation

tannuiscoding
Copy link
Contributor

close #185

it also closes #187

changes I made

  • added offline.py with all the offline usable functions
  • reduced redundancy by adding password.py
  • improved clip() and show() functions by reducing the same code

Copy link
Contributor Author

@tannuiscoding tannuiscoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice to me

@iamyaash
Copy link
Collaborator

iamyaash commented Nov 2, 2024

@tannuiscoding now that we have this combined into a single file, and the test cases are failing.

it was written for separate files!

@iamyaash
Copy link
Collaborator

iamyaash commented Nov 2, 2024

don't delete the old files (for now)
let's keep it

we'll raise the "test case" issue for that, then we'll remove it from the project!

@iamyaash
Copy link
Collaborator

iamyaash commented Nov 2, 2024

also make separate PRs!
for each issue that you were assigned on

it's better if you close this PR and make a new one!

@jindalpriyanshu101
Copy link
Member

jindalpriyanshu101 commented Nov 2, 2024

also make separate PRs! for each issue that you were assigned on

it's better if you close this PR and make a new one!

@this-is-yaash Simply merge this PR as level-2 as it solves two level1 issues. It'll save some time.

@tannuiscoding tannuiscoding deleted the offline branch November 3, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants