Skip to content

Commit

Permalink
Merge pull request #1246 from AmadeusITGroup/feature/knip
Browse files Browse the repository at this point in the history
feat: setup knip
  • Loading branch information
vscaiceanu-1a authored Dec 13, 2024
2 parents 3787065 + 89ff1cf commit 5b9e1da
Show file tree
Hide file tree
Showing 6 changed files with 190 additions and 1,356 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Check Markdown links
name: Code checks

on:
pull_request:
Expand All @@ -10,9 +10,18 @@ jobs:
markdown-link-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v4
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
config-file: '.github/workflows/markdown.links.config.json'
check-modified-files-only: 'yes'
use-verbose-mode: 'yes'
knip:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- name: Yarn install
run: yarn --immutable
- name: Run knip
run: yarn knip
8 changes: 2 additions & 6 deletions examples/my-ngsw-app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions knip.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import type { KnipConfig } from 'knip';

const config: KnipConfig = {
ignore: ['examples/**'],
entry: ['src/schematics/ng-add/index.ts', 'src/index.ts'],
ignoreBinaries: ['playwright']
}

export default config;
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@
},
"devDependencies": {
"@angular-devkit/schematics": "~19.0.4",
"@angular/cli": "~19.0.4",
"@schematics/angular": "~19.0.4",
"@types/jest": "^29.5.12",
"@types/mustache": "^4.2.5",
"@types/node": "^20.14.2",
Expand All @@ -52,8 +50,8 @@
"copyfiles": "^2.4.1",
"eslint": "^8.56.0",
"jest": "^29.7.0",
"knip": "^5.0.1",
"rimraf": "^6.0.0",
"rxjs": "^7.8.1",
"ts-jest": "^29.1.1",
"type-fest": "^4.19.0"
}
Expand Down
1 change: 1 addition & 0 deletions testing/tsconfig.spec.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"extends": "../tsconfig",
"types": ["node", "jest"],
"include": [
"./**/*.spec.ts"
]
Expand Down
Loading

0 comments on commit 5b9e1da

Please sign in to comment.