compat for NPM lifecycle scripts #9262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Apr 22, 2024
Deploying agoric-sdk with
|
| Latest commit: |
3f64e43
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9aa4aac.agoric-sdk.pages.dev |
| Branch Preview URL: | https://8288-npm-compat.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8288
Description
ui-kit was recently bumped to Yarn 4 and @samsiegart hit a snag that required patching : Agoric/ui-kit@464f61d
This removes
yarndependence in NPM lifecycle scripts. It does so by usingnpm run, which should be available everywhere. In Node 22 we'll havenode --runavailable.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
working in Agoric/ui-kit@464f61d
Upgrade Considerations
none