Letting dep_codecs/build.sh inherit C[XX]FLAGS content #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_C_FLAGS in cmake cache - if not pre-defined - is initialised using environment variables in combination with builtin defaults for the toolchain If it is passed as an argument to the cmake configuration command, only the defined values will be cached. Inheriting flags (e.g. optimisation options) from environment variables is not possible in this configuration Passing the "-fPIC" flag however can also be done without affecting CFLAGS inheritance via setting the CMAKE_POSITION_INDEPENDENT_CODE cmake variable
|
@yilun-zhangs or @yongmin-kwon, Any complaints? Otherwise this PR looks good to me. It seems this a more standard way to set the PIC flag for these libraries. Also it does not break the GitHub CI builds. |
jwcullen
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_C_FLAGS in cmake cache - if not pre-defined - is initialised using environment variables in combination with builtin defaults for the toolchain If it is passed as an argument to the cmake configuration command, only the defined values will be cached. Inheriting flags (e.g. optimisation options) from environment variables is not possible in this configuration Passing the "-fPIC" flag however can also be done without affecting CFLAGS inheritance via setting the CMAKE_POSITION_INDEPENDENT_CODE cmake variable