Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CacheProvider still be used? #1459

Open
michael-markl opened this issue Oct 2, 2024 · 0 comments
Open

Should CacheProvider still be used? #1459

michael-markl opened this issue Oct 2, 2024 · 0 comments

Comments

@michael-markl
Copy link

michael-markl commented Oct 2, 2024

Describe the issue

It is not documented (unless I missed something) whether the CacheProvider widget should still be used.

In some examples (https://github.com/zino-hofmann/graphql-flutter/blob/main/packages/graphql_flutter/example/lib/graphql_widget/main.dart#L29) it is still used, and in some examples (https://github.com/zino-hofmann/graphql-flutter/blob/main/examples/starwars/lib/view/client/graphql_view.dart#L22) it is not used.

Also, its implementation consists of mostly commented out code, so I am not even sure, if CacheProvider in its current state does anything except checking that a GraphqlClient exists in the context (?).

If it is no longer of any use, I think the two options are:
(a) Just remove the class entirely, potentially breaking users
(b) Deprecate the class and add a comment that it should no longer be used.

If there is still a use case for CacheProvider, then it should be documented somewhere.

If I understand something wrong, I apologize in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@michael-markl and others