-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing movie set posters in Collection View #1111
Comments
Maybe you already found signs towards the issue in your debug log. I have seen and aware of multiple issues and situations where Kodi is not providing information (thumbnails, labels, ...) through JSON API even though visible inside Kodi. Especially around thumbnail creation there were several problems in the past, so for now I assume this is the same here. But let's look into the details of the API response. As I remember you can issue JSON commands, it will be helpful, if you can run the same on your end and see what responses come back. Command to ask for movie sets and related metadata:
Example response (first movie set in my test database)
The remote app will now look for "poster" inside "art" (preferred) or "thumbnail" as a fallback. In above case the preferred data is shared:
This is converted into a URL which allows to download the image from your Kodi instance (IP and port as per your configuration). You can literally open this with a standard web browser:
Please issue the JSON command and review the response. I assume that either no "thumbnail" or "poster" is shared, or that the file cannot be loaded (e.g. when no thumbnail was created internally). Both would point to problems inside Kodi itself. But let's see. |
Thanks for your help wutschel. You do indeed remember correctly: I can dig as deep/get as technical as you would like and would be happy to provide the requested JSON queries & responses. A quick aside: As an FYI to any future readers that might come across this via a Google search, the test library I'm using to troubleshoot this issue is only 3 movies large, but each movie has a complete set of fan arts, posters, disc arts, actor arts, etc. When I conduct each test I use the following procedure: Testing procedure
Now on to the requested information: JSON query results
Well that's surprising... The Directory listing of non-working Movie Set folderUsing the "Analyze Collection" (setid: 2) as an example, here's the full directory listing of the folder.
To my eyes, it looks like the files are all named correctly (based on my reading of the Kodi Wiki at Movie Sets Artwork and Movie Sets Information Folder), but maybe I'm missing something here? Any thoughts on this unexpected development would be welcome, especially since Kodi doesn't seem to have any issue displaying this on the TV. Could you post a listing of the directory structure of the working set you used above ( Contents of non-working movie set .NFO
Could you post a dump of the working .NFO you used above ( Thanks for the clue on where to continue my troubleshooting! If I could have your help getting the above two pieces of info (directory listing and dump of a relevant .NFO), that would help even further. |
The good news is: Now it is clear why the app does not show any cover. It is just not shared. The bad news is that I cannot really help too much further. For my test database I just used a scraper, there are no nfo files or movie sets folders. @kambala-decapitator, you have a Kodi developer in mind who could look into this? PS: The only thing I wondered about is whether you should use the key 'poster' instead of 'thumb' in your nfo. |
Ah, I see, well I still appreciate the response nonetheless! The 'poster' vs. 'thumb' idea is a good one. I'll give that a try and see if I can debug things further. |
Can ask in the team chat. But what should I ask about exactly? Sorry, haven't followed all the comments here, only understood that it's something about posters. |
Sure, this is about scanning movie sets to database via .nfo files (detailed nfo above). The posters are not shared via JSON API even though shown in Kodi UI. |
Kodi does not use this. There is no such thing as a "collection.nfo" file in the Kodi world.
Have you set up the MSIF? It's a bit hard to tell with all the snippets. Can you delete the movies from your library, rescan them and provide a debug log. |
@KarellenX, thanks for looking into this as well. For my test database the app loads posters for each of the (17) sets: https://ibb.co/vhq2tBk Your JSON response looks like expected ("art" holding "poster"), and the app should attempt to load the images. Can you see issues in the Kodi logs when the app tries to download the images? In the past there have been issues where Kodi was not creating the thumbnails internally and therefor the app could not download the respective images. See xbmc/xbmc#23956. |
Here is my Kodi log... https://paste.kodi.tv/javiyageqo.kodi |
Hmm, this shows the same pattern as @gavinstevenson reported
Looks to me like something not going right inside Kodi. Or do you see any issue with the request to download the image? |
This is the pr for the MSIF... xbmc/xbmc#16970 |
Hi @wutschel, @KarellenX, I see this thread has progressed quite a bit over the last few hours, but just in case it's still helpful, I'll answer the questions that were asked from a few hours ago:
Yes.
Yes:
No, per the wiki, the MSIF and the video file directories are separate. The wiki specifically advises against creating the MSIF folder inside another Kodi source folder (i.e., "do not create [the MSIF directory] inside your movie or tv show source folders"). If I should instead be creating these in the same folder, please let me know. The wiki may need to be updated. The MSIF directory is:
Sure. I included a relevant snippet above, but if you're curious for a full debug output, please see link here. (Warning: it's several thousand lines long. See below for line numbers to relevant excerpts.) Some quick searching through the log seems to indicate that Kodi is correctly locating the Movie Sets collection folders and is correctly slurping up the associated Line numbers and excerpts from above debug log file illustrating that Kodi is finding the movie set folders:
Line numbers and excerpts from above debug log file illustrating that Kodi is caching the movie set artwork:
Line numbers and excerpts from above debug log file illustrating (potentially spurious) messages about no matching sources for pieces of artwork:
Ah, that's surprising. I assumed that when a user had "Local information provider only" selected when scanning new items into a database, the same code responsible for scanning .NFOs for local movies and music would also support movie sets .NFOs. Does this then mean that even when a user has "Local information provider only" selected when scanning movies, whatever code is responsible for ingesting movie sets will always go out to some kind of external information provider to scrape things like plot summaries? If so, then I can see value in adding .NFO support to movie collections for all the same reasons .NFOs for other source types are supported (namely, being able to control what's added in your local database without having to rely on an external 3rd party). |
The Set/Collection data comes from the nfo file from the movie. <set>
<name>Bourne Collection</name>
<overview>The Bourne films are a series of action thriller movies...</overview>
</set> |
Ah, interesting. In that case, what's the expected behavior when one movie in a set contains one I believe I've seen this before with several long-lived franchises like the Fast and the Furious movie sets, the Harry Potter movie set, the John Wick movie set, etc. |
IIRC, the most recent will overwrite the existing. |
Should this be moved to Kodi? I cannot see the iOS app doing anything about this. |
Hi @wutschel, I'd be supportive of doing so. As you indicated in #1111 (comment) and #1111 (comment) and #1111 (comment), the app can only work with the data it getting from Kodi. If that's not going right, there's only so much you'll be able to do. Further, as @KarellenX in #1111 (comment), he's seeing the same behavior, which leads me to believe this is a bona fide bug. Do you have the ability to move this bug to the main xbmc repo (thus preserving all the debug/investigation work above)? |
@kambala-decapitator, can this issue be moved to the xbmc project? Otherwise it should be closed as we cannot do anything on the App side. |
I currently have a small test library that contains several movies split into 2 movie sets/collections:
When I view these sets/collections within Kodi, the associated artwork (
poster.jpg
,fanart.jpg
) and metadata (the string from the<overview>
tag) displays correctly. However, when I use the iOS remote, the app does not load the image or overview data.Here's an excerpt I get from a debug log when navigating to the Collection View using Kodi's default Estuary skin on the TV:
Note the two lines at the bottom:
I suspect these two debug log messages are spurious because even though they claim "no matching source found for [path-to-the-poster.jpg]", Kodi is obviously able to locate and load the images just fine as illustrated in the below screenshot of the Kodi interface running on my HTPC.
But when I use the iOS app to try to view the collections,
the poster.jpg
for the relevant movie sets doesn't load.Any thoughts or ideas on how I can get the app to display the
poster.jpg
s for the movie collections?Screenshot of Kodi interface on TV illustrating working movie set posters.
Note: ignore the crude bright-red writing on the poster. I'm using that to confirm Kodi is picking up local artwork and not scraping the poster.jpg from some website like TMDB or something.
Screenshot of App illustrating blank/not-loaded movie set posters.
Dump of a relevant movie set .NFO:
Movie set appears to be correctly recognized in the database:
The text was updated successfully, but these errors were encountered: