Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some genres #94

Open
elyaB opened this issue Oct 25, 2019 · 6 comments · May be fixed by #95
Open

Change some genres #94

elyaB opened this issue Oct 25, 2019 · 6 comments · May be fixed by #95

Comments

@elyaB
Copy link
Contributor

elyaB commented Oct 25, 2019

We need to change some genre otherwise it will be very complicated to find what we are looking for :

  • english-jazz => jazz
  • english-rock => rock
  • english-rap => rap
  • english-pop => pop

english-rap and spanish-rap would be in the same folders for example. This way, it would be so much simplier.

(Just imagine if we were going to add a new genre for every language !)

I wonder for the reggaeton. We can think of an architecture of sub genres. We could do it this way :

  • reggaeton
    |_ reggaeton-new.md
    |_ reggaeton-oldschool.md

I've already done it, I just wait for someone to tell me "Ok !"

@elyaB elyaB changed the title Change some genre Change some genres Oct 25, 2019
@elyaB elyaB linked a pull request Oct 25, 2019 that will close this issue
@xaca
Copy link
Owner

xaca commented Nov 4, 2019

@elyaB I like your architecture, the genres are a lot now, we must to organized them.

@MisoMosiSpy
Copy link
Contributor

Should we have one more level for languages itself?
Folder will be names as
/language/genre/genre.md

@elyaB
Copy link
Contributor Author

elyaB commented Nov 5, 2019

No, it would create the same problem as before !
I'll take an exemple. The user knows what genre he wants to listen to. He doesn't know which language he wants.
If we do like this :
language/genre/genre.md
The user would have to look at every language. We can have like 50 different languages, it would be awful.
If we do as this :
genre/language/language.md
The user would only have to go through his desire genre, then look at all the languages.

If you ask me, I already find it odd to classify by languages. I mean, these are the same genres. When I'm looking for music, I'm looking for a specific genre, not a language. Spotify playlists, for example, are made by genres, not languages.

@elyaB
Copy link
Contributor Author

elyaB commented Nov 5, 2019

Like, if you take classical music, do you classify it as "Hungarian Classical" and "German Classical" ? Even though it has no lyrics ?
We don't want to go down the rabbit hole of classifying by languages.

@MisoMosiSpy
Copy link
Contributor

Like, if you take classical music, do you classify it as "Hungarian Classical" and "German Classical" ? Even though it has no lyrics ?
We don't want to go down the rabbit hole of classifying by languages.

Sure, whatever works for majority is fine.

@xaca
Copy link
Owner

xaca commented Nov 5, 2019

@elyaB You're right. At the beginning We only have a couple of genres, now there are a lot of list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants