Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--git-tag does not commit Cargo.lock #24

Open
zkat opened this issue Jun 26, 2019 · 5 comments · Fixed by LevitatingBusinessMan/cargo-bump#1 · May be fixed by #36
Open

--git-tag does not commit Cargo.lock #24

zkat opened this issue Jun 26, 2019 · 5 comments · Fixed by LevitatingBusinessMan/cargo-bump#1 · May be fixed by #36

Comments

@zkat
Copy link

zkat commented Jun 26, 2019

Every time I do cargo bump -g now, I get Cargo.lock as a modified file in my project root, after the commit :(

@wraithan
Copy link
Owner

I thought it was the next cargo build after cargo bump -g which then updates the Cargo.lock. Not the cargo bump -g itself. I can test that soon to be sure.

@rubik83
Copy link

rubik83 commented Mar 19, 2020

This bug is also visible in the release of cargo-bumb itself
In this zip :
https://github.com/wraithan/cargo-bump/archive/1.1.0.zip
In Cargo.lock line 65 : version = "1.0.2"
The version of cargo-bump is bad

@gibfahn
Copy link

gibfahn commented May 6, 2020

I thought it was the next cargo build after cargo bump -g which then updates the Cargo.lock. Not the cargo bump -g itself. I can test that soon to be sure.

Yeah this is true, but ideally the bump commit would include the change to the Cargo.lock as well.

@Stargateur
Copy link

cargo bump -g should do a cargo check

@LevitatingBusinessMan LevitatingBusinessMan linked a pull request May 24, 2023 that will close this issue
@LevitatingBusinessMan
Copy link

I solved this in my branch by having cargo generate the lockfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants