-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove language translation check from core update process #192
Remove language translation check from core update process #192
Conversation
Skip cache also when ZIP URL is 'http://' to nightly build
…aned -> cleaning typo.
…porting Update tests enable error reporting
* Regenerates README.md * Adds `.github/settings.yml` for description and label management. * Updates `.github/PULL_REQUEST_TEMPLATE`
Ignore SSL trigger_error in WP get_core_checksums() on core upgrade.
Update scaffolded README and GitHub configuration
…maries) to use third-person singular verbs.
Convert core command help summaries to use third-person singular verbs.
Fix GitHub label generation
Replace "install" with "installation" where appropriate
Convert 'install' -> 'installation' in all the correct places
Move wp-cli/wp-cli-tests to dev dependecies and update
…try-by-default
Regenerate README file
This does prevent the markup and error within the terminal, but one apparent consequence is that the user needs to manually update translations, for example with the |
The general philosophy of WP-CLI is that commands should only solve one single unique problem (i.e. updating core). It makes sense that the languages need to be updated separately via CLI. |
This will still need a test to ensure the language installation is reliably disabled across all WP versions. Let me know if you need help getting started with Behat testing. (I'll also have to figure out what the current test failures are about.) |
@bgturner Are you still up for working on this and implement the needed test? |
Sorry for dropping this. I've been pulled to other things. If someone else wants to take this initial work and run with it, I'd be happy for it to be solved. Otherwise, I can probably circle around later in August |
Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/d61dbf890608fe24eb2ab2ed526f438a in case this PR is auto-closed or broken in some way. |
d289b58
to
762c7ce
Compare
Fixes #191