Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete LOCK from MySQL #145

Open
whywaita opened this issue Jun 22, 2022 · 1 comment
Open

Delete LOCK from MySQL #145

whywaita opened this issue Jun 22, 2022 · 1 comment

Comments

@whywaita
Copy link
Owner

myshoes check the status of LOCK in MySQL during starting.

if err := m.ds.GetLock(ctx); err != nil {

But this implementation has a bug. A deadlock occurred in some environments like Kubernetes (from high-frequency restart).

@whywaita
Copy link
Owner Author

Proposal:

  • Add new column owner to job
    • myshoes will update CONNECTION_ID() in MySQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant