Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd support #54

Open
ricea opened this issue Apr 3, 2023 · 10 comments
Open

zstd support #54

ricea opened this issue Apr 3, 2023 · 10 comments

Comments

@ricea
Copy link
Collaborator

ricea commented Apr 3, 2023

Issue for discussion of adding support for the zstd format to the API.

@ricea
Copy link
Collaborator Author

ricea commented Apr 3, 2023

Currently libzstd is not linked into Chromium. It would add roughly 700KB to the binary size (maybe can be trimmed a bit). This would be a hard sell if the compression standard is the only user.

@evanstade
Copy link

It seems that you did manage to trim the size a bit as this change only added 38k. Was that just by dropping everything besides decompression, or were there other tricks you made use of?

On the storage team we are also interested in using zstd for compressing IndexedDB values before sending them over IPC (or storing as blobs). Adding the compression half of zstd appears to add another 200kB.

So that's at least two users of zstd.

@ricea
Copy link
Collaborator Author

ricea commented Jul 18, 2023

We didn't do anything special in Chromium to reduce the size increase, except for only compiling in the decompression code. I think we were just lucky.

I would like to move this specification to WHATWG before we add new features, since it is now implemented in Firefox and Safari and we would like to have consensus.

That means it will probably be some months before there's movement on adding zstd.

@saschanaz
Copy link
Member

I would like to move this specification to WHATWG before we add new features, since it is now implemented in Firefox and Safari and we would like to have consensus.

Why would it take that much to move to WHATWG?

@telgareith
Copy link

Note: Chrome/Chromium, Firefox, and Opera have agreed to add zstd to content-encoding options. Chrome is planning on General Availability in 118.

@Jedipedia
Copy link

Another note: Firefox now supports Content-Encoding: zstd as of version 126 but there's still no support for new DecompressionStream("zstd") in either Firefox or Chromium.

@xpl
Copy link

xpl commented Jun 24, 2024

Please add it to the specification, as it seemingly blocks from implementing new DecompressionStream("zstd") in browsers:

https://issues.chromium.org/issues/348499728

Screenshot 2024-06-24 at 12 10 32

@saschanaz
Copy link
Member

#34 (comment)

Just as brotli, we'd be open to ship only DecompressionStream support for zstd, as @jesup reported 600KB size increase to ship the compression side of the library.

@ricea
Copy link
Collaborator Author

ricea commented Sep 11, 2024

#34 (comment)

Just as brotli, we'd be open to ship only DecompressionStream support for zstd, as @jesup reported 600KB size increase to ship the compression side of the library.

Thanks. I think this will also be Blink's position.

@nektro
Copy link

nektro commented Sep 27, 2024

Bun would be interested in supporting this since we already ship with zstd support internally for other APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

8 participants
@xpl @evanstade @saschanaz @nektro @ricea @Jedipedia @telgareith and others