Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit STJ dependency for net 8 #46

Open
thompson-tomo opened this issue Apr 13, 2024 · 2 comments · May be fixed by #47
Open

Remove explicit STJ dependency for net 8 #46

thompson-tomo opened this issue Apr 13, 2024 · 2 comments · May be fixed by #47

Comments

@thompson-tomo
Copy link

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like
I want the package to not have an explicit dependency on System.Text.Json as it can be provided by the framework.

Describe alternatives you've considered
Accept the additional dependency

Additional context
n/a
thompson-tomo added a commit to thompson-tomo/system-text-json-jsondiffpatch that referenced this issue Apr 22, 2024
@thompson-tomo
weichch#46 Optimise STJ to not be included in net 8 as framework prov…
844b7bd 
…ides it
@thompson-tomo thompson-tomo linked a pull request Apr 22, 2024 that will close this issue
Open
@Numpsy
Copy link

Numpsy commented Aug 7, 2024

On a semi-related note, the version 8.0.0 System.Text.Json NuGet package that is currently being referenced is listed as suffering from GHSA-hh2w-p6rv-4g7w, and using the inbox version of System.Text.Json where possible might help to minimize that sort of issue.

@thompson-tomo
Copy link
Author

@Numpsy Totally agree by leveraging framework dependencies where ever possible we can reduce effort on package maintainers while helping to make less vulnerable dotnet eco-system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Numpsy @thompson-tomo