Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-save to Install #70

Open
ericclemmons opened this issue Sep 20, 2016 · 2 comments
Open

Double-save to Install #70

ericclemmons opened this issue Sep 20, 2016 · 2 comments

Comments

@ericclemmons
Copy link
Member

The cynics have no problem killing processes, restarting servers, & having a crappy workflow to npm install dependencies, but have a problem with maybe accidentally installing a dependency because they've carelessly typo-d lodsh. 👀

Anyway, I think it'd be legit if:

  1. First save with a missing dependency threw an error (before Webpack got to it!) saying the dependency is missing. Heck, copying the error format could be useful?
  2. The second time saving the file (dunno if plugins will still fire knowing nothing has changed!) would save & install the dep.
Whoa there! `lodash` hasn't been installed yet!
Save your file again to install `lodash` automatically...
@ericclemmons
Copy link
Member Author

@insin I think this would help resolve some of my personal paint-points with this project. What do you think?

@insin
Copy link
Collaborator

insin commented Jan 22, 2017

Can you detect which specific file changes triggered a rebuild?

If the problem is typos, it could get kind of annoying when you haven't made one.

How about an option to ping npm to check if a module a) exists and if possible b) isn't typosquatting? (auto-install uses number of downloads in the last month for this when you use its --secure flag) before going back to the user for a double-save "are you sure"?

(So hardcoding a check for boostrap)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants